Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support customizing the serverLogoutSuccessHandler for OidcClientInitiatedServerLogoutSuccessHandler #14808

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add support customizing the serverLogoutSuccessHandler for OidcClientInitiatedServerLogoutSuccessHandler #14808

wants to merge 1 commit into from

Conversation

franticticktick
Copy link
Contributor

Closes gh-14778

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 27, 2024
@jzheaux jzheaux added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: blocked An issue that's blocked on an external project change and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 1, 2024
@jzheaux jzheaux self-assigned this Apr 1, 2024
jzheaux
jzheaux requested changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @CrazyParanoid! I've left my feedback inline.

...rity/oauth2/client/oidc/web/server/logout/OidcClientInitiatedServerLogoutSuccessHandler.java Outdated Show resolved Hide resolved
...rity/oauth2/client/oidc/web/server/logout/OidcClientInitiatedServerLogoutSuccessHandler.java Outdated Show resolved Hide resolved
@franticticktick franticticktick requested a review from jzheaux April 19, 2024 09:13
@jzheaux jzheaux added type: enhancement A general enhancement and removed status: blocked An issue that's blocked on an external project change labels Apr 25, 2024
@jzheaux jzheaux added this to the 6.4.0-M1 milestone Apr 26, 2024
@marcusdacoregio marcusdacoregio modified the milestones: 6.4.0-M1, 6.4.0-M2 Jul 15, 2024
@sjohnr sjohnr modified the milestones: 6.4.0-M2, 6.4.0-M3 Aug 19, 2024
@marcusdacoregio marcusdacoregio modified the milestones: 6.4.0-M3, 6.4.0-M4 Aug 22, 2024
@jzheaux jzheaux modified the milestones: 6.4.0-M4, 6.4.0-RC1 Sep 16, 2024
@jzheaux jzheaux removed this from the 6.4.0-RC1 milestone Oct 14, 2024
@jzheaux jzheaux added this to the 6.5.x milestone Nov 21, 2024
@jzheaux
Copy link
Contributor

jzheaux commented Nov 21, 2024

@franticticktick, sorry for the delay on this one. Can you do one more thing for me and change the @since to 6.5? Then we'll merge once we cut the 6.4.x branch

@jzheaux jzheaux mentioned this pull request Nov 21, 2024
Closed
@franticticktick
Copy link
Contributor Author

Hi @jzheaux, done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux jzheaux approved these changes

Assignees

@jzheaux jzheaux

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Projects
None yet
Milestone
6.5.x
Development

Successfully merging this pull request may close these issues.

Support customizing the redirect URL in OidcClientInitiatedServerLogoutSuccessHandler
5 participants
@franticticktick @jzheaux @sjohnr @marcusdacoregio @spring-projects-issues